apify-client-js icon indicating copy to clipboard operation
apify-client-js copied to clipboard

Remove/address depth limitation of parseDateFields

Open tobice opened this issue 11 months ago • 2 comments

parseDateFields traverses the provided JSON (used for Apify API responses) and converts certain fields to a Date object. The traversion depth has been historically limited to 3, possibly to avoid cyclic dependencies and improve performance on large responses.

This limitation is not communicated in any way, which might lead to weird surprises. We tried adding a log.warning but that led to log pollution as there are objects with arbitrary structure that went over the depth limit (most likely user data, data sets). Context here.

Possible solutions:

  • Remove the limitation
  • Stop parsing objects with arbitrary structure (user data, data sets)

Both are potential breaking changes.

This is currently not causing any issues and can be treated with low priority.

tobice avatar Feb 26 '24 09:02 tobice

Let's check with @B4nan, but I guess this is low-prio for now.

drobnikj avatar Feb 28 '24 09:02 drobnikj

Yeah, this can wait, we just wanted to have this tracked. It sounds like a good first issue for some new joiners.

B4nan avatar Feb 28 '24 09:02 B4nan