etcd-adapter icon indicating copy to clipboard operation
etcd-adapter copied to clipboard

Add E2E test framework

Open tokers opened this issue 2 years ago • 6 comments

Besides basic unit test cases, we need to setup the E2E test framework, to verify changes are feasible.

The logic here is creating some APISIX resources, and use ETCD adapter as the configuration center, pushing changes to APISIX, and send requests to APISIX to check if the results are good.

Note, we need run E2E test cases multiple times for each backend.

tokers avatar Mar 15 '22 00:03 tokers

@membphis @bzp2010

tokers avatar Mar 15 '22 00:03 tokers

I see @bzp2010 is writing some new features for this project, I recommend setting up the E2E framework firstly, or you cannot find some potential bugs in the new PR.

tokers avatar Mar 15 '22 00:03 tokers

Can we use the same testing framework as APISIX-Dashboard?

membphis avatar Mar 15 '22 00:03 membphis

Can we use the same testing framework as APISIX-Dashboard?

Maybe, but the part for feeding configurations should be changed as we don't support all features that Manager API / Admin API needs.

tokers avatar Mar 15 '22 01:03 tokers

Maybe, but the part for feeding configurations should be changed as we don't support all features that Manager API / Admin API needs.

@tokers you are right

membphis avatar Mar 15 '22 01:03 membphis

Update

A draft of the E2E framework has been made available here https://github.com/api7/etcd-adapter/pull/12, which uses the same testing framework as the APISIX Dashboard (i.e. ginkgo, but upgraded to v2).

bzp2010 avatar Mar 16 '22 16:03 bzp2010