apisix-build-tools icon indicating copy to clipboard operation
apisix-build-tools copied to clipboard

Published 20 hours ago • verified publisher icon api7

feat: Improve pnpm support for dashboard build scripts.

Open FangSen9000 opened this issue 2 years ago • 7 comments

I am working on the APISIX dashboard project to migrate its package manager from yarn to pnpm. His GitHub workflow uses this script to detect RPM packaging. We need some minor changes to make the workflow work normally. https://github.com/apache/apisix-dashboard/pull/2604

FangSen9000 avatar Aug 15 '22 07:08 FangSen9000

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 15 '22 07:08 CLAassistant

Looks like that this PR isn't finished yet?

tzssangglass avatar Aug 15 '22 14:08 tzssangglass

Looks like that this PR isn't finished yet?

Yes, but if the apisix build tool is not changed during the merge, the packaged RPM workflow of the merged PR will have an error. (after all, you are upstream of RPM workflow)

Do you want to copy this script to the local warehouse or request you to change this tool. We need to discuss it for some time. At that time, we will close this PR or request changes to the merge tool.

FangSen9000 avatar Aug 15 '22 15:08 FangSen9000

~~WIP, however, I can be sure that all the changes to the tool are just these two lines~~

Update, the task has been completed at https://github.com/apache/apisix-dashboard/pull/2604 now

Wait for @bzp2010 's opinions

FangSen9000 avatar Aug 15 '22 15:08 FangSen9000

ping @bzp2010 does this PR is needed?

tzssangglass avatar Aug 21 '22 15:08 tzssangglass

@FangSen9000

I think we need to wait for the PR merge in the APISIX Dashboard project before doing this.

BTW, I don't think using pnpm in the build session will help a lot with build speed, but it will improve our development experience.

bzp2010 avatar Aug 25 '22 06:08 bzp2010

@FangSen9000

I think we need to wait for the PR merge in the APISIX Dashboard project before doing this.

BTW, I don't think using pnpm in the build session will help a lot with build speed, but it will improve our development experience. ok

FangSen9000 avatar Aug 25 '22 06:08 FangSen9000