Andrew Fitzgerald

It seems we also may want different solutions for old vs new scheduler. Old scheduler has a high probability that locking will fail, but new scheduler have near-zero lock-failures. So...

I have a branch which will log datapoints from the submitting thread so the proper thread-name appears: metrics-logged-from-submitting-thread example: ``` [2024-01-23T19:28:46.632093987Z INFO solana_core::replay_stage] [solReplayStage] datapoint: replay-loop-voting-stats generate_vote_us=210i update_commitment_cache_us=6i [2024-01-23T19:28:46.632112522Z INFO...

https://github.com/solana-labs/solana/pull/34865/files#diff-ed47b4a0198313377e091bb3957bbbc63d937805426d1b2b6de39d0a50d32a0cR6673 I think getting it off the fee generator was incorrect here. Seems like the right way would probably be to get it off of the blockhash queue for the...

I think I finally have a reasonably good understanding of how your scheduling works (much easier with trimmed down PR! ❤️ ). As I'm thinking on this, I think this...

> sans the big rename Page => UsageQueue and my take on comparison with prio-graph, i think i should have addressed all review comments so far. so, I'm requesting another...

@lijunwangs or @CriesofCarrots do you have thoughts on the proposed solution? It seems like the current behavior contributes to priority fees not working as well as they should, although there...

> This feels a little dogmatic to me. It should really be up to the RPC operators how they want to filter or prioritize transactions. We could think about ways...

> the mutex is required, so we would be able to drop transactions that are already in process > > https://github.com/solana-labs/solana/blob/9dca15a5b7a6e0938e45b3249156d84b51832c27/send-transaction-service/src/send_transaction_service.rs#L434-L451 > > it's possible to drop mutex in send...

Change looks good to me, there's a test which seems to be testing this behavior though. AFAICT we do not expect this to be anything other than the fee-structure's value...

@AshwinSekar Am I way off here? This appears to be no longer necessary since your changes to the vote threads have now landed.