nova-typescript icon indicating copy to clipboard operation
nova-typescript copied to clipboard

Performance issues after Nova 9

Open sgwilym opened this issue 2 years ago • 10 comments

After updating to Nova 9 I'm starting to experience some performance issues with this extension. It's hard to pin down and give proper reproduction instructions, but here's what I've noticed:

  • The extension struggles to keep up with my typing, ofter only updating contextual information after several seconds.
  • One time when opening code actions for a line, I could see code actions for past states of the file, e.g. Add missing function declaration 's', Add missing function declaration 'su' Add missing function declaration 'sub' Add missing function declaration 'subt', etc. all listed at once. Almost as though many LSP servers were active at once.
  • This problem seems to get worse the longer a file is.

sgwilym avatar Mar 23 '22 15:03 sgwilym

I'm also experiencing these performance issues post Nova 9.

geoffb avatar Apr 05 '22 20:04 geoffb

I'm also experiencing these issues. Most common spot I notice is after a ; newline, the editor'll freeze, as if it's processing something

lkellar avatar Apr 13 '22 19:04 lkellar

CleanShot 2022-04-13 at 14 48 18 Turning off completions seems to resolve it, at least for me, but this isn't great

lkellar avatar Apr 13 '22 19:04 lkellar

Same here. It is very annoying. @apexskier are you aware of it and are you still involved in this extension? Thanks. 😊

TheJoffrey avatar May 06 '22 19:05 TheJoffrey

Yeah, I'm still aware, sorry for the lack of response on my part. I'm hoping to have more time to support this next month, but I'll try to get to any PRs if I see them before then.

Unfortunately, I don't have any immediate ideas on how to fix a performance issue like this, so it'll take some deep diving. Please make sure you're reporting to Panic as well, since it was associated with a major version change.

apexskier avatar May 06 '22 19:05 apexskier

Yeah, I'm still aware, sorry for the lack of response on my part. I'm hoping to have more time to support this next month, but I'll try to get to any PRs if I see them before then.

Unfortunately, I don't have any immediate ideas on how to fix a performance issue like this, so it'll take some deep diving. Please make sure you're reporting to Panic as well, since it was associated with a major version change.

Thanks for your answer! I will report it to Panic.

TheJoffrey avatar May 08 '22 05:05 TheJoffrey

I've upgraded the underlying typescript-language-server from v0.5.4 to v0.11.0 (changelog). There's a chance that this will have helped here, please report back.

apexskier avatar Jun 12 '22 22:06 apexskier

Haven't noticed issues 2 and 3 in my initial usage (installed today) but I'm experiencing lots of lag and hitches when typing (including rainbow wheel) on Nova 9.3, M1 Pro.

DominicHolmes avatar Jun 16 '22 15:06 DominicHolmes

I am experiencing this issue as well and had to disable this extension to be able to type. I do remember it being a small issue a year ago on my Mac Mini with some stalling.

Now I'm on a Mac Studio M1 Max, and while typing, it often stalls and it'll show the "beach ball of death" which spins for up to 10 seconds before resuming and then stalling again soon after if I continue typing on the same line — it seems random too.

The performance issues on Mac Studio compared to the Mac Mini (Intel) is worse.

danjguzman avatar Jun 17 '22 00:06 danjguzman

I'm also experiencing this issue.

davidbdyer avatar Aug 03 '22 19:08 davidbdyer

I've upgraded the underlying language server and bundled typescript version, can you check this again?

apexskier avatar Jan 16 '23 22:01 apexskier

It's still slow for me.

lucasfischer avatar Feb 23 '23 14:02 lucasfischer

Painfully slow as of Nova 11.4.

I noticed a lot of folks are mentioning performance issues on Apple Silicon Macs, but I'd like to chime in here that my Intel i9 (2.3 GHz 8-core) MacBook is experiencing the same issue. I don't think this is isolated to Apple Silicon.

And, I'm not sure it seems to be a Nova problem as suggested earlier. Disabling this extension resolves all performance issues in the editor -- even when using other extensions that provide completions from language servers.

Sam-Spencer avatar Aug 30 '23 15:08 Sam-Spencer

⚠️ Archived: Although it was fun to build my nova extensions, I haven't ended up using Nova regularly and can't devote the time to maintenance. Feel free to reach out if you want to fork and start maintaining an alternative.

apexskier avatar Dec 25 '23 23:12 apexskier