react-apexcharts icon indicating copy to clipboard operation
react-apexcharts copied to clipboard

fix: props requirement, npmignore, readme

Open falsepopsky opened this issue 3 years ago • 1 comments

Fix

Types

  • TS make type, series and options required, not optional (now TS should say you are missing this props)
  • PropTypes removed any in favour of string and number

Upgrade dependency

  • prop-types

.npmignore

  • Added some files that are not needed when you install this package (.vscode, src, etc) package

Readme

  • Fixed typo in height description, and some description and formats.

falsepopsky avatar Jul 10 '22 19:07 falsepopsky

@junedchhipa

When i run build script, Gulp throws an error. my way to fix this was changing the import in react-apexcharts.jsx file

this import ApexCharts from 'apexcharts/dist/apexcharts.common' to => import ApexCharts from 'apexcharts'

falsepopsky avatar Jul 10 '22 19:07 falsepopsky

@falsepopsky Sorry for the delayed response. Please regenerate the package-json and yarn lock files to resolve conflicts.

junedchhipa avatar Sep 10 '22 08:09 junedchhipa

@junedchhipa no problem, already done.

falsepopsky avatar Sep 10 '22 19:09 falsepopsky