up icon indicating copy to clipboard operation
up copied to clipboard

Removing a VPC configuration doesn't reset to defaults of "No VPC"

Open kaihendry opened this issue 7 years ago • 2 comments

0.7.3-pro

Description

When removing a vpc configuration, a following deployment doesn't reset the deployment to the default "No VPC"

Steps to Reproduce

Remove a VPC configuration from up.json and re-deploy. https://media.dev.unee-t.com/2018-09-05/up-sg.mp4

Work around is to up stack delete and re-deploy, which obviously takes a lot longer.

kaihendry avatar Sep 05 '18 09:09 kaihendry

fixed in c0e6f655e81fd2f0b042dae2f1f0fd1a59163be6 but I have to add a warning for people who manually assigned VPC to move it to up.json before I can do another release there

tj avatar Sep 05 '18 12:09 tj

nvm, reverted that commit, I don't think there's any clean way to tell if it was manually configured or simply removed from up.json. I can't really introduce c0e6f65 without breaking existing deployments that were manually tweaked to use VPC (I think at least a dozen people configured it this way).

I'll add a note in the documentation that vpc has to be manually removed in the console for now

tj avatar Sep 05 '18 15:09 tj