Fix support for Node 0.10 which was broken by #3

Open victorquinn opened this issue 9 years ago • 3 comments

While it was nice that #3 added support for Node 4.3 on Lambda, it totally broke Node 0.10 on Lambda causing requests with errors to time out.

This PR fixes it so this module works with both.

Jul 28 '16 17:07 victorquinn

I think it's fair to say most people would be just using 4.3 going forward, for that reason I don't think it's necessary

Jul 28 '16 20:07 tj

Possibly though it unexpectedly broke all of my existing apex functions when I updated this module and I spent awhile pulling my hair out trying to figure out why the requests were timing out. Didn't seem too complex to make it backwards compatible.

Anyway, if you don't want to accept this PR I'll open another that at least updates the README to inform people that if they're using Node 0.10 on Lambda they need to use 1.x and not 2.x

Jul 28 '16 20:07 victorquinn

Ah, yea we should have had a changelog note for that, I'll add something

Jul 28 '16 21:07 tj