log icon indicating copy to clipboard operation
log copied to clipboard

Have log.Fielder return a map[string]interface{} ?

Open matthewmueller opened this issue 6 years ago • 1 comments

Right now you can't implement a custom fielder without pulling in the apex/log library.

I'm not sure if this would be a breaking change or not, but it'd be nice to change:

type Fielder interface {
	Fields() Fields
}

to this:

type Fielder interface {
	Fields() map[string]interface{}
}

matthewmueller avatar Jul 25 '18 09:07 matthewmueller

true true, might be nice for the 2.0 there were going to be some other small breakages anyway, sounds reasonable to me!

tj avatar Jul 25 '18 16:07 tj