force-di icon indicating copy to clipboard operation
force-di copied to clipboard

Add field to binding obj to filter active records

Open aronowt opened this issue 4 years ago • 4 comments

This change is Reviewable

aronowt avatar Jun 24 '20 11:06 aronowt

@aronowt for backwards compatibility this change needs to consider null values in Active__c as active. cc @ImJohnMDaniel thoughts?

afawcett avatar Jul 20 '20 18:07 afawcett

@aranowt -- While the change is certainly straightforward and I echo @afawcett's requested changes, my larger question is why would you need to do this? Why would you have bindings deployed that are not active?

ImJohnMDaniel avatar Jan 24 '21 16:01 ImJohnMDaniel

We have two uses for it at the moment.

  1. Deploy items as soon as the development is completed and activate it only when it's supposed to go live. It would be easier to find what to activate if the binding is there but deactivated, as opposed to not being there at all.
  2. Deactivate certain processes when doing a data load.

On Sun, Jan 24, 2021, 11:05 AM John M. Daniel [email protected] wrote:

@aranowt -- While the change is certainly straightforward and I echo @afawcett https://github.com/afawcett's requested changes, my larger question is why would you need to do this? Why would you have bindings deployed that are not active?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apex-enterprise-patterns/force-di/pull/62#issuecomment-766373650, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACBILWY4LVOMFNLBFPCIFTLS3RAM7ANCNFSM4OGS3MUQ .

aronowt avatar Jan 24 '21 21:01 aronowt

@aronowt If a binding is not active and a process calls for that binding, there would be an error. If you are using the bindings as "feature switches", then this may not be the best way to do that. The purpose of the bindings provide a way for you change implementations and limit what needs to be deployed as part of that change. It also supports unit test mock swap-out of implementations.

Am I understanding your use case correctly or am I missing something?

ImJohnMDaniel avatar Jan 24 '21 22:01 ImJohnMDaniel