force-di icon indicating copy to clipboard operation
force-di copied to clipboard

Add git tags for versions

Open mark-feeney-sage opened this issue 5 years ago • 3 comments

It would be great to be able to reference a version by git tag, for development and dependency management. Is there a reason not to do so? Versions with no corresponding tags are already cited in sfdx-project.json.

mark-feeney-sage avatar Mar 01 '19 11:03 mark-feeney-sage

Hey @mark-feeney-sage -- So, basically, you are asking for us to reference stable points in time of the project by GIT tags since this is a non-packaged project and thus can't make use of version numbers. Am I understanding your ask correctly?

ImJohnMDaniel avatar Mar 01 '19 16:03 ImJohnMDaniel

Hi @ImJohnMDaniel. If that is the case (non-packaged, no version numbers), yes, it would be handy. I thought there were version numbers, as referenced in those sfdx project package aliases. If there's some other means by which others use this library in production, or I'm missing some Salesforce pattern that's normally used, it'd be great to know.

mark-feeney-sage avatar Mar 03 '19 20:03 mark-feeney-sage

Hey @mark-feeney-sage -- Thanks for the clarification.

Yeah, @afawcett, @douglascayers, and I have been going back and forth about whether or not maintain a packaged version of this project or simply maintain the codebase and let the developers who use the code to decide how they want to package it. Personally, I have this packaged as part of a larger, 'foundation package' at work and I have a client that has it as an independent/standalone package. The choice is totally up to you.

As for a 'stable release marker', it is not a bad idea. Something we can discuss going forward.

Andy and Doug -- any thoughts?

ImJohnMDaniel avatar Mar 05 '19 01:03 ImJohnMDaniel