fflib-apex-common icon indicating copy to clipboard operation
fflib-apex-common copied to clipboard

Published 20 hours ago • verified publisher icon apex-enterprise-patterns

Make sure method return non-null values

Open wimvelzeboer opened this issue 2 years ago • 2 comments

After upgrading my projects to the latest fflib-apex-common, where some methods were moved from fflib-apex-extensions to fflib-apex-common, I found that a high number of unit-tests were failing.

Then I found out that the getIdFieldValues and getStringFieldValues were suddenly also returning null values, which makes no sense. This fix will make sure these methods always return the values and omit the nulls

This change is Reviewable

wimvelzeboer avatar May 27 '22 12:05 wimvelzeboer

@wimvelzeboer, can you also please check fflib_SObjectsTest.itShouldReturnFieldValues test method. It failed in the CI run for this PR

ImJohnMDaniel avatar May 27 '22 13:05 ImJohnMDaniel

@wimvelzeboer, the fflib_SObjectsTest.itShouldReturnFieldValues() test method is still failing with the following error

System.AssertException: Assertion Failed                                
Class.fflib_SObjectsTest.itShouldReturnFieldValues: line 146, column 1

Can you take a look at this please?

ImJohnMDaniel avatar Aug 02 '22 14:08 ImJohnMDaniel