rpncalc icon indicating copy to clipboard operation
rpncalc copied to clipboard

[WV] Enable project to run on other plataforms. (Web, Mac, Linux, Windows)

Open wviana opened this issue 1 year ago • 3 comments

For it was need all those changes, it was also added a .sdk for using sdk use and having the right versions for gradle, java and kotlin.

TODO: Add build instructions using sdk man in README file.

  • Tested on Linux and Android.
  • As I had to replace ButtonTheme by ElevatedButton I messed a bit with some colors and others, we should review it before merging, maybe ElevatedButton is not the right replacement for it.

For installing sdkman use curl -s "https://get.sdkman.io" | bash than inside project folder use sdk env install && sdk env use

PS: RpnCalc is my main calculator for some time now, I would love to contribute to keep it. Thank you for building this awesome app. PS1: My first time hammering flutter. Loving it.

wviana avatar Mar 05 '23 20:03 wviana

Thanks for the PR! I've been meaning to get back to rpncalc so this is very timely. I'm working on upgrading rpncalc to use the current flutter version (it's way behind right now...), so once I've got that working I'll take a look at including these changes.

apesic avatar Mar 06 '23 19:03 apesic

This is pretty much what was done here. These are the versions I'm running this code:

Flutter 3.7.6 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 12cb4eb7a0 (5 days ago) • 2023-03-01 10:29:26 -0800
Engine • revision ada363ee93
Tools • Dart 2.19.3 • DevTools 2.20.1

Try running this code version, there are a few tweaks to make it look just as I was before. I've notice that the ElevatedButton is not 100% matching the style we had. Also I changed the enter button color for testing and forgot to change it back.

But the main thing here was upgrading to latest version so it allowed to run on Browser and Linux. iOS, Mac and Windows should be working too.

wviana avatar Mar 07 '23 03:03 wviana

Hey @apesic you are right. Looks like being able to use latest version to run doesn't means it uses the latest features. For example I was testing to use enchanted enums, but for it the minimum SDK value have to be changed. Anyways this is a good first steps into this direction.

wviana avatar Mar 07 '23 10:03 wviana