vue-chartjs icon indicating copy to clipboard operation
vue-chartjs copied to clipboard

Published 20 hours ago • verified publisher icon apertureless

WIP: Feat/vitest

Open victorgarciaesgi opened this issue 2 years ago • 2 comments

WIP

Ehancement: Replace Jest with Vitest

Not sure if it adds a lot of value, but I wanted to test the migration as I've done it on vue-chart-3.

WIP because I still have problem to make Vue files imports work on /legacy and had to keep Jest for this part.

  • [x] All tests passed

Environment

  • OS: macOs 12.1
  • NPM Version: 8.5.5

victorgarciaesgi avatar May 06 '22 14:05 victorgarciaesgi

@victorgarciaesgi I think we don't need to test legacy components with Vitest. If you want to add a Vitest to the project, it may be better to add it only for Vue 3 and leave Jest for View2. What are you think about this?

thabarbados avatar May 19 '22 10:05 thabarbados

@thabarbados Ok! I will test further to see if nothing breaks for vue 3. But it can improve speed and reduce dependencies size!

victorgarciaesgi avatar May 23 '22 15:05 victorgarciaesgi

done in https://github.com/apertureless/vue-chartjs/commit/c664db51c3d39bf9f2d8042dc47bf05b7b9e2bc9

dangreen avatar Nov 29 '22 16:11 dangreen