WikiExtractor
WikiExtractor copied to clipboard
apertium
update the constant name and imports
Constants name is transformed into all uppercase and remove an unimportant comment in import and removed some unimportant imports in urllib module.
I can't quite see what this change achieves, @jonorthwash I think you'll have to decide if it's something we want
I can't quite see what this change achieves, @jonorthwash I think you'll have to decide if it's something we want
would you like to add Multiprocessing or Multithreading to speed up the extraction peocess or Logging functionality in the project?
@ai-naymul, you accidentally inverted the deletion in the commit. You kept all the files that we wanted gone, and removed the one file that had real changes.
@ai-naymul, you accidentally inverted the deletion in the commit. You kept all the files that we wanted gone, and removed the one file that had real changes.
@TinoDidriksen I am extremely sorry for that, What should I do now, could you please suggest me?
Roll back your commit and remove the other files.
@TinoDidriksen How can I do that could you please help me or should I made another pr?
Undo commit 547c64244d5c985e96a40f0becec3eb054b1a7e2 and remove the .idea folder instead.
@TinoDidriksen You mean I should revert the commit remove all those .idea files...?
Like that...
Something like that, yes. The changeset should only be changes to WikiExtractor.py - we don't want any generated files added, especially not IDE-specific ones.
Something like that, yes. The changeset should only be changes to
WikiExtractor.py- we don't want any generated files added, especially not IDE-specific ones.
Okay then let me make the revert, Thanks a lot for your help❤
Something like that, yes. The changeset should only be changes to
WikiExtractor.py- we don't want any generated files added, especially not IDE-specific ones.
I have made an another commit could you please check that give me feedback?
You didn't revert everything from the commit. You need to go back to commit https://github.com/ai-naymul/WikiExtractor/commit/0f313a9dbd59c8a2d1d25e61f10e2ffbf5989290 and remove the .idea folder from that state.
You didn't revert everything from the commit. You need to go back to commit ai-naymul@0f313a9 and remove the .idea folder from that state.
Should I make another commit in this regarding there are some error is troughing while I tried to delete the whole idea file?
@ai-naymul As it stands now, your pull request makes literally 0 changes. Additionally, it's still not clear what was gained by the original change. What is the value of renaming those variables and very slightly reformatting the import lines?
Whether you add a 4th commit with the actual changes, or rewrite history to remove some commits and then remove the folder, is really up to you. If we merge, we'll squash it in so it looks like a single commit anyway.
@ai-naymul As it stands now, your pull request makes literally 0 changes. Additionally, it's still not clear what was gained by the original change. What is the value of renaming those variables and very slightly reformatting the
importlines?
It helps to read the code better but however If think It's not worthy you can closed the PR and if you like I would love to work on another things to improve the project :)
No, you misunderstand. Right now, this PR literally does nothing. There are no changes in https://github.com/apertium/WikiExtractor/pull/4/files - you've managed to remove everything, not just the .idea folder.
No, you misunderstand. Right now, this PR literally does nothing. There are no changes in https://github.com/apertium/WikiExtractor/pull/4/files - you've managed to remove everything, not just the
.ideafolder.
What should I do now?
I repeat: You need to go back to commit https://github.com/ai-naymul/WikiExtractor/commit/0f313a9dbd59c8a2d1d25e61f10e2ffbf5989290 and remove the .idea folder from that state.
I repeat: You need to go back to commit ai-naymul@0f313a9 and remove the .idea folder from that state.
Bro I mean how can I delete the folder from that commit could you please give me some guide to make that, I will be very gratefull for that... :)
Something like:
git reset --hard 0f313a9dbd59c8a2d1d25e61f10e2ffbf5989290
rm -rf .idea
git commit --all -m "Removed folder"
git push -f
Something like:
git reset --hard 0f313a9dbd59c8a2d1d25e61f10e2ffbf5989290 rm -rf .idea git commit --all -m "Removed folder" git push -f
@TinoDidriksen Is that fine now?