mod_auth_cas Cleanup config parsing

Can someone take a look at this? I forgot to submit this a while ago. Basically, tries to make the config parsing block less of an eyesore.

Oct 09 '12 19:10 pames

Some nits but mostly LGTM. I would suggest to rebase and squash it into sensible commits.

Nov 08 '12 01:11 bnoordhuis

OK, I think I addressed all your comments, and I tried to rebase/squash but I have no clue if I did it right :-)

Nov 08 '12 03:11 pames

Okay, so ideally you'd do something like this:

$ git fetch origin
$ git rebase origin/master
# fix merge conflicts, if any
$ git rebase -i origin/master

And end up with two commits - one that removes CASAllowWildcardCert, the other that reworks option parsing - that you can fast-forward merge into the master branch (if you were working from a feature-branch). You get bonus karma for nice kernel-style commit logs. :-)

Aside from that, it LGTM.

Nov 08 '12 04:11 bnoordhuis