Use of error.h in mod_auth_cas.c

Open kinghuang opened this issue 9 years ago • 3 comments

I'm having a tough time building mod_auth_cas on httpd:2.4.23-alpine (Alpine Linux), as opposed to httpd:2.4.23 (Debian). mod_auth_cas.c imports <error.h>, which isn't provided by musl/libc-dev on Alpine.

Is error.h strictly needed? I scanned through mod_auth_cas.c, but couldn't find an obvious use of it.

Oct 31 '16 15:10 kinghuang

I believe it's used for errno.

Oct 31 '16 16:10 pames

errno.h does exist for both Debian and Alpine, and can be imported specifically. It doesn't look like error.h imports errno.h, directly or indirectly.

I've commented out #include <error.h> to complete the build on Alpine with no immediate ill effects. If nothing goes wrong in local testing, I'll submit a PR.

Oct 31 '16 17:10 kinghuang

same kind of error under FreeBSD:

mod_auth_cas.c:25:10: fatal error: 'error.h' file not found
#include <error.h>
         ^
1 error generated.
apxs:Error: Command failed with rc=65536

Dec 10 '16 13:12 dgeo