java-cas-client icon indicating copy to clipboard operation
java-cas-client copied to clipboard

CASC-216 support session fixation by implement HttpSessionIdListener …

Open sammyhk opened this issue 3 years ago • 2 comments

…in SingleSignOutHttpSessionListener

sammyhk avatar May 13 '21 06:05 sammyhk

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 16 '22 05:04 stale[bot]

I didn't expect a stale bot here.

Emkas avatar Apr 16 '22 07:04 Emkas

@mmoayyed Why this is closed without any comment?

Emkas avatar Apr 24 '23 06:04 Emkas

Comment is, this was opened 2 years ago and there has been no activity or interest since then. We'll close and can revisit later.

mmoayyed avatar Apr 24 '23 07:04 mmoayyed

What other interest do you need? The change is done. Without ANY interest from Apareo. No comment, no asking for rebase etc. Do you want authors to ask about any attention once in the week? Once in a month? Once in the quarter? Please give us some guidance.

Like stale bot and some other "no unit tests" bot is not enough.

How can you expect any interest since you gave none. I've watched several PR in this project and all of them have no feedback. And now. All of them are closed. Looks like only PR this project can handle are one from the dependency bot.

Emkas avatar Apr 24 '23 07:04 Emkas

I'm the author of original PR, I contributed the issue of https://apereo.atlassian.net/browse/CASC-216 2 years before, and no one reviewed or merged. Now some random guys just popup and closed the PR. Maybe this project is dead?

sammyhk avatar Apr 24 '23 07:04 sammyhk

Interestingly, I just checked the original issue https://apereo.atlassian.net/browse/CASC-216 which created in December 27, 2013, almost 10 years before without someone to fix. Maybe that is what they called "no interest".

sammyhk avatar Apr 24 '23 07:04 sammyhk

Allow me to clarify: since this change was posted two years ago, no project member has shown interest or time to review, verify and accept the change. So we are cleaning up. If and when someone from the project decides to spend time here, we'll be glad to restart the process.

mmoayyed avatar Apr 24 '23 07:04 mmoayyed

Yeah, closed PR are much more likely to get anyone's attention. That's the best way to "clean up" things.

Emkas avatar Apr 24 '23 13:04 Emkas