dotnet-cas-client icon indicating copy to clipboard operation
dotnet-cas-client copied to clipboard

Develop

Open jffcovey opened this issue 4 years ago • 8 comments

I would like to contribute a bug fix related to this library and Internet Explorer. The issue is outlined in this blog post. https://blogs.perficient.com/2017/03/27/troubleshooting-the-redirect-issue-of-net-cas-integration-in-ie/

jffcovey avatar Jan 06 '21 14:01 jffcovey

Which versions of IE does this effect?

phantomtypist avatar Jan 06 '21 15:01 phantomtypist

Did you also try the most recent version of the nuget package to see if the problem actually still existed? The problem they described in the four year old blog article is a TLS related problem for a cyclical redirect issue. From what I can tell they just made a bandaid fix, but the problem was still there in reality.

If I am wrong, please provide fully reproduction scenario, including version of IE, with most current nuget package, step by step, so that we can test and verify the problem still exists.

phantomtypist avatar Jan 06 '21 15:01 phantomtypist

Sorry, this is my first time trying to contribute to a project on Github. I forked, pushed my changes and created a new pull request.

jffcovey avatar Jan 06 '21 15:01 jffcovey

@jffcovey you didn't have to close the issue, just answer the questions I asked. I mean, you put in all that effort writing that blog post back in 2017 and the investigative debugging, I figured it wasn't too much to ask of you to test your problem against the latest release in nuget to see if the problem was still there or not.

phantomtypist avatar Jan 06 '21 16:01 phantomtypist

I didn't write that blog. I ran across it while triaging a bug that we have with the latest nuget package(1.3.2). If you try to use it with IE 11 I think you will see the same behavior. I created a new pull request with the code change we implemented that fixed the issue. We're fine with maintaining our own customized version of the code, but just thought it would be helpful to contribute back to the project.

jffcovey avatar Jan 07 '21 14:01 jffcovey

What version of TLS is both the web application server running and the CAS server running? What version of. Net is your application compiled against (be specific)

phantomtypist avatar Jan 07 '21 15:01 phantomtypist

Both servers are running TLS 1.2 and we are using .NET Framework 4.6.1 to compile our application. Also, version 1.3.2 of DotNetCasClient.

jffcovey avatar Jan 07 '21 16:01 jffcovey

Is there anything else you need from me?

jffcovey avatar Jan 11 '21 14:01 jffcovey