cas icon indicating copy to clipboard operation
cas copied to clipboard

Add logout support for OIDC in authn delegation

Open leleuj opened this issue 1 year ago • 8 comments

After a delegated authentication at an OIDC provider, if this OIDC provider sends a logout request to the CAS server, the CAS server does not perform a CAS logout. It works for SAML though.

This PR fixes the problem and adds a test to confirm the behavior.

leleuj avatar Jun 21 '24 14:06 leleuj

I will investigate on failing tests.

leleuj avatar Jun 24 '24 09:06 leleuj

I think the Publish documentation issue is not related to my change.

leleuj avatar Jun 24 '24 09:06 leleuj

The delegation issue:

Execution failed for task ':support:cas-server-support-pac4j-webflow:testDelegation'.
> Failure closing session
  Standard error from JVM:
      OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended

does not seem to be related to my change either.

leleuj avatar Jun 24 '24 09:06 leleuj

Re-running failing tests to confirm the outcome...

leleuj avatar Jun 24 '24 10:06 leleuj

After re-running the failing tests, the SAML2 tests pass while the delegation tests still don't but I see the same issue on the master. Thus, I consider that this PR is not the culprit. Keep me posted if you need me to fix something in any case...

leleuj avatar Jun 24 '24 12:06 leleuj

Thank you, sure. I'll take a look shortly.

mmoayyed avatar Jun 24 '24 15:06 mmoayyed

This generally looks OK, thank you. I am in the process of moving OIDC/SAML2 functionality out of the main module for delegated authn, and when done, I'll also merge and include this changeset there in the final result. I am hoping to do this before the weekend.

mmoayyed avatar Jun 26 '24 04:06 mmoayyed

Good! Thanks

leleuj avatar Jun 26 '24 05:06 leleuj

This pull request has been open and inactive. It will be closed shortly.

github-actions[bot] avatar Jul 04 '24 00:07 github-actions[bot]

This is merged into the master branch

mmoayyed avatar Jul 05 '24 11:07 mmoayyed