gitbuilder icon indicating copy to clipboard operation
gitbuilder copied to clipboard

runlock: unhandled error case when 'exec' does return

Open bAndie91 opened this issue 7 years ago • 1 comments

https://github.com/apenwarr/gitbuilder/blob/bf70974a8e70b544b771b30b0849e12a398887ff/runlock#L42

hi i noticed it is not handled when exec does return. see perldoc:

It fails and returns false only if the command does not exist

so NOTREACHED is actually reached sometime

cheers.

bAndie91 avatar Nov 09 '18 13:11 bAndie91

Yeah, that's a good point, though it doesn't come up very often I guess :)

apenwarr avatar Nov 18 '18 07:11 apenwarr