TensoRF icon indicating copy to clipboard operation
TensoRF copied to clipboard

Different logic to compute nSamples in two different places

Open NagabhushanSN95 opened this issue 1 year ago • 0 comments

Hi, I noticed you're computing nSamples in two different places with slightly different logic. In utils.py, it is simple logic. We need two samples for every unit length of voxels, so you compute the voxel/tensor grid diagonal length and multiply it by 2. But in tensorBase.py, there is some complicated logic that I guess is only slightly different from the former.

Can you kindly explain if this has any impact, or is it just a simple oversight?

NagabhushanSN95 avatar Aug 09 '23 22:08 NagabhushanSN95