ruby-shadow icon indicating copy to clipboard operation
ruby-shadow copied to clipboard

extconf.rb: use Rbconfig::CONFIG instead of mkmf CONFIG

Open mtasaka opened this issue 2 years ago • 2 comments

In mkmf.rb CONFIG is defined as CONFIG is defined as RbConfig::MAKEFILE_CONFIG and RbConfig::MAKEFILE_CONFIG is almost same as RbConfig::CONFIG except that RbConfig::MAKEFILE_CONFIG uses reference for other variables.

Using CONFIG in extconf.rb causes error with ruby3.2 because now CONFIG['host_os'] uses reference for target_os variable, and extconf.rb expects that this variable is all expanded. So instead, use RbConfig::CONFIG .

Closes #30

mtasaka avatar Dec 01 '22 03:12 mtasaka

I've released a gem that includes this PR, in order to allow Ruby 3.2 users to keep using this gem's functionality.

64kramsystem avatar May 02 '23 10:05 64kramsystem

Hello, Can a fix be made available for "getting shadow.so: undefined symbol: rb_tainted_str_new2 with ruby-shadow-ruby32-2.5.1.gem.", please? On Linux, using Ruby 3.2.2, getting shadow.so: undefined symbol: rb_tainted_str_new2 with ruby-shadow-ruby32-2.5.1.gem.

The following code in this gem uses rb_tainted_str_new2: pwd/shadow.c:59: rb_tainted_str_new2(entry->pw_name), /* sp_namp / pwd/shadow.c:60: rb_tainted_str_new2(entry->pw_passwd), / sp_pwdp, encryped password / pwd/shadow.c:69: rb_tainted_str_new2(entry->pw_class), / sp_loginclass, user access class */ shadow/shadow.c:37: rb_tainted_str_new2(entry->sp_namp), shadow/shadow.c:38: rb_tainted_str_new2(entry->sp_pwdp),

Created an issue for this: https://github.com/apalmblad/ruby-shadow/issues/34

Thanks.

jay4git avatar Jan 09 '24 17:01 jay4git