select2-bootstrap-5-theme icon indicating copy to clipboard operation
select2-bootstrap-5-theme copied to clipboard

Update _variables.scss

Open dariocarbone opened this issue 1 year ago • 5 comments

Quick fix for bootstrap 5.3.0

See: https://github.com/apalfrey/select2-bootstrap-5-theme/issues/75#issuecomment-1416307961

dariocarbone avatar Jun 01 '23 09:06 dariocarbone

Hi,

Replacing $s2bs5-border-color with raw red color is not so good solution.

Originally there is $s2bs5-border-color variable used. If you trace it to final definition you would have this chain of assignments: $s2bs5-border-color = $form-select-border-color = $input-border-color = $border-color

So correct solution would be to change line 28 of _variables.scss from:

$s2bs5-border-color:             var(--#{$prefix}form-select-border-color) !default;

to

$s2bs5-border-color:             $border-color !default;

This eliminates compilation bug and does not changes color value in variable.

f1mishutka avatar Jun 02 '23 07:06 f1mishutka

Fast solution before this PR is merged is to add this line before importing select2-bootstrap-5-theme:

$s2bs5-border-color: $border-color;

f1mishutka avatar Jun 02 '23 07:06 f1mishutka

Thanks, you're absolutely right: this is a better solution, promptly committed to master branch

dariocarbone avatar Jun 15 '23 07:06 dariocarbone

Any update on this?

mmarton avatar Oct 03 '23 11:10 mmarton

Any news ?

Jir4 avatar Nov 29 '23 15:11 Jir4