apalache
apalache copied to clipboard
Rewrite enabled
- [x] Tests added for any new code
- [x] Ran
make fmt-fix
(or had formatting run automatically on all files edited) - [x] Documentation added for any new functionality
- [x] Entries added to ./unreleased/ for any new functionality
This is experimental - it might be fragile. I've tried to cover a variety of cases with integration tests, but I'm unsure it will work for all possible inputs. However, this will only have an effect on specs that contain ENABLED, so I'm fairly confident that it won't randomly break a spec that worked fine before.
The branch name is an artifact of the fact that during dev, the branch was similarly to #1874 squashed to remove old bogus commits.
closes #800
Codecov Report
Merging #1883 (18b2dd2) into unstable (3cd0afe) will decrease coverage by
0.37%
. The diff coverage is33.63%
.
:exclamation: Current head 18b2dd2 differs from pull request most recent head 288f0f7. Consider uploading reports for the commit 288f0f7 to get more accurate results
@@ Coverage Diff @@
## unstable #1883 +/- ##
============================================
- Coverage 76.83% 76.45% -0.38%
============================================
Files 402 404 +2
Lines 12501 12606 +105
Branches 576 589 +13
============================================
+ Hits 9605 9638 +33
- Misses 2896 2968 +72
Impacted Files | Coverage Δ | |
---|---|---|
...yte/apalache/tla/assignments/EnabledRewriter.scala | 0.00% <0.00%> (ø) |
|
...a/assignments/passes/EnabledRewriterPassImpl.scala | 0.00% <0.00%> (ø) |
|
...syte/apalache/tla/bmcmt/config/CheckerModule.scala | 0.00% <0.00%> (ø) |
|
...syte/apalache/io/lir/ItfCounterexampleWriter.scala | 91.83% <ø> (ø) |
|
...cala/at/forsyte/apalache/io/lir/PrettyWriter.scala | 89.18% <ø> (ø) |
|
...syte/apalache/tla/pp/passes/TemporalPassImpl.scala | 0.00% <0.00%> (ø) |
|
...la/at/forsyte/apalache/tla/pp/temporal/utils.scala | 90.90% <50.00%> (-9.10%) |
:arrow_down: |
...n/scala/at/forsyte/apalache/tla/pp/Desugarer.scala | 85.00% <100.00%> (+3.00%) |
:arrow_up: |
...syte/apalache/tla/pp/temporal/TableauEncoder.scala | 91.66% <100.00%> (+0.75%) |
:arrow_up: |
...a/at/forsyte/apalache/tla/lir/ModuleProperty.scala | 100.00% <100.00%> (ø) |
|
... and 2 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3cd0afe...288f0f7. Read the comment docs.
As we discussed today, I'm taking over this PR, since Philip's internship is over.
Unassigning myself as reviewer to take this off my review roster. Feel free to re-request me when this is ready for review.
I'm closing this as part of a new years cleanup of the review. We'll leave the branch in case we want to renew work on this at some point.