Kevin

Results 112 comments of Kevin

It looks like what happens with a core formula when the core tap is not installed is that we load it from the keg and then use the path the...

That makes sense to me. Looking at things a bit more, I see now that the `bump-*-pr` commands already do that as of a few years ago. That approach should...

I'm hoping that I've addressed all of the feedback in https://github.com/Homebrew/brew/pull/17153/commits/6ad02b8e340e163ce90beccb33d0f297d96e7b03. Let me know if there's anything I've missed. It adds a new test for a formula with uses from...

> > The biggest risk here is that it affects JSON generation for the public formula JSON v2 format or that the current JSON parsing logic doesn't work the same...

@Homebrew/cask It'd be great to hear your opinion on this topic.

> > * Only store the Ruby cask file > > > > This would make things much simpler on our end but would require an extra network request to...

> Great discussion. I think there a benefits to storing it as a JSON file because it allows us to store additional information, such as the tap that the cask...

So the [method_source](https://github.com/banister/method_source) gem only stores the code for the block/proc itself but not any surrounding variables that it closes over. This should be fine for internal use with the...

> > This should be fine for internal use with the main cask repo but could cause problems for third-party taps. > > We should optimise for our own use...

> This is something we can audit for, adjust the way we evaluate the DSL (i.e. what scope we use and what variables are captured), warn/deprecate/error for at installation time,...