zookeeper icon indicating copy to clipboard operation
zookeeper copied to clipboard

Published 20 hours ago • verified publisher icon apache

ZOOKEEPER-1621: Delete and skip txn log with incomplete header

Open jbequinn opened this issue 5 years ago • 5 comments

Based on the patch by Michi Mutsuzaki.

Modify FileTxnIterator to skip a transaction log file (instead of throwing an IOException) if the header is incomplete.

jbequinn avatar Jun 11 '19 14:06 jbequinn

Comes from #439

jbequinn avatar Jun 11 '19 14:06 jbequinn

very nice - lgtm

enixon avatar Jun 11 '19 17:06 enixon

Could this be backported to 3.4? We're using Solr cloud 7.6, which comes with Zookeeper 3.4 bundled, and I'm not sure if it would work with 3.5.

jbequinn avatar Jun 12 '19 20:06 jbequinn

@jbequinn Thanks for picking this up. @lvfangmin We might want to add a feature switch to this patch and/or create a "recycle bin"-like folder and moving corrupted txn log files instead of deleting them. What do you think?

anmolnar avatar Jun 25 '19 20:06 anmolnar

@anmolnar agreed, probably add a feature flag and turn this off by default first before we gain confidence.

lvfangmin avatar Jul 22 '19 19:07 lvfangmin