zookeeper icon indicating copy to clipboard operation
zookeeper copied to clipboard

ZOOKEEPER-4394: Learner.syncWithLeader got NullPointerException

Open jeffrey-xiao opened this issue 3 years ago • 3 comments

This PR resolves ZOOKEEPER-4394.

The first commit adds a failing test that demonstrates that a leader sending an outstanding proposal during a DIFF will cause an NPE if the commit to the proposal comes before the UPTODATE.

The second commit fixes the failing test and addresses the problem by splitting packetsNotCommitted to a separate field called packetsNotLogged. The former keeps track of packets that needs to be committed while the latter keeps track of packets that needs to be logged.

See individual commit messages for more details.

jeffrey-xiao avatar Sep 30 '22 14:09 jeffrey-xiao

:warning: 52 God Classes were detected by Lift in this project. Visit the Lift web console for more details.

sonatype-lift[bot] avatar Sep 30 '22 15:09 sonatype-lift[bot]

Is this PR getting superseded by #2152?

tsuna avatar Jun 13 '24 12:06 tsuna

Ping

tsuna avatar Aug 08 '24 15:08 tsuna

Is this PR getting superseded by #2152?

@kezhuw Do you agree? Can we close this patch in favor of #2152 ?

anmolnar avatar Sep 18 '24 16:09 anmolnar

I would prefer #2152. @anmolnar

kezhuw avatar Sep 19 '24 05:09 kezhuw