zookeeper icon indicating copy to clipboard operation
zookeeper copied to clipboard

ZOOKEEPER-4303: Allow configuring client port to 0

Open madrob opened this issue 2 years ago • 4 comments

https://issues.apache.org/jira/browse/ZOOKEEPER-4303

Allows specifying an explicit port 0 for the client port or secure client port, which will default to operating system behavior of finding an unbound port. Modified ZKServerEmbedded to report the actual port instead of the configured port.

madrob avatar Apr 25 '22 17:04 madrob

I'm not able to reproduce the failure seen by the GitHub actions, can somebody help me figure out if this is caused by my changes or an existing issue?

madrob avatar May 02 '22 21:05 madrob

Force pushed rebase to development branch.

madrob avatar May 31 '22 14:05 madrob

I have restarted CI

eolivelli avatar Jun 21 '22 10:06 eolivelli

@maoling @symat Could you please take a look at this ? It is valuable in testing/embedded environments to avoid port conflict. It is ZooKeeper's CURATOR-535.

kezhuw avatar Sep 05 '22 14:09 kezhuw

@eolivelli @symat Shall we merge this ?

kezhuw avatar Oct 10 '22 01:10 kezhuw

sorry for the delay, I kind of forgot about this one, I can merge it :( @eolivelli - can I merge this or do we need an other test run here? (is there any way to re-trigger the failing pr-merge jenkins job? - I don't even remember which one is that or if it is important)

symat avatar Oct 11 '22 17:10 symat

I think that we can merge it. you could restart the job by logging into jenkins using your ASF credentials.

I believe it is useless now that we have GH actions, I already started a discussion on dev@

eolivelli avatar Oct 11 '22 19:10 eolivelli

yes, I agree to eliminate some of these CI jobs. I'll merge this PR now.

symat avatar Oct 11 '22 20:10 symat

merge is done, thank you @madrob for your contribution! and for your patience ;)

symat avatar Oct 11 '22 20:10 symat

@eolivelli @symat Would you mind merging this to 3.7 and 3.8 ? apache/curator#421 needs this.

kezhuw avatar Feb 05 '23 12:02 kezhuw