zookeeper icon indicating copy to clipboard operation
zookeeper copied to clipboard

ZOOKEEPER-3837: Deprecate StringUtils Functions

Open belugabehr opened this issue 5 years ago • 4 comments

belugabehr avatar May 19 '20 14:05 belugabehr

[WARNING] /home/travis/build/apache/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/admin/ZooKeeperAdmin.java:[319,24] joinStrings(java.util.List<java.lang.String>,java.lang.String) in org.apache.zookeeper.common.StringUtils has been deprecated [INFO] 6 warnings [INFO] ------------------------------------------------------------- [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /home/travis/build/apache/zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/admin/ZooKeeperAdmin.java: warnings found and -Werror specified [INFO] 1 error

That's unfortunate that I can't deprecate things.

belugabehr avatar May 19 '20 15:05 belugabehr

Oh, you got that error because you don't supress the warning, or even better, just fix it up there also!

nkalmar avatar May 20 '20 17:05 nkalmar

I would also deprecate the split to be honest. I'm not fan of implementing something so general ourselves, especially that java already is pretty good ad string operations, but we also have apache.io. Didn't dig into it, but probably there is some one liner for a split similar.

nkalmar avatar May 20 '20 17:05 nkalmar

I would also deprecate the split to be honest. I'm not fan of implementing something so general ourselves, especially that java already is pretty good ad string operations, but we also have apache.io. Didn't dig into it, but probably there is some one liner for a split similar.

Ya, I looked into this, and I can, but I didn't because it's not exactly the same since it trims each result.

belugabehr avatar May 21 '20 13:05 belugabehr