zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

[ZEPPELIN-6358] Add E2E tests about /#/notebook/:noteid for New UI

Open dididy opened this issue 2 months ago • 2 comments

What is this PR for?

Addition and improvement of notebook-related E2E tests for New UI


/#/notebook/:noteId – View or edit a specific notebook /#/notebook/:noteId/revision/:revisionId – View a specific revision of a notebook /#/notebook/:noteId/paragraph/:paragraphId – Notebook paragraph presentation mode

PAGES.WORKSPACE.NOTEBOOK → src/app/pages/workspace/notebook/notebook.component

PAGES.WORKSPACE.NOTEBOOK_ACTION_BAR → src/app/pages/workspace/notebook/action-bar/action-bar.component

PAGES.WORKSPACE.NOTEBOOK_PARAGRAPH → src/app/pages/workspace/notebook/paragraph/paragraph.component

PAGES.WORKSPACE.NOTEBOOK_SIDEBAR → src/app/pages/workspace/notebook/sidebar/sidebar.component

PAGES.WORKSPACE.PUBLISHED_PARAGRAPH → src/app/pages/workspace/published/paragraph/paragraph.component

What type of PR is it?

Improvement

Todos

What is the Jira issue?

ZEPPELIN-6358

How should this be tested?

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

dididy avatar Oct 11 '25 14:10 dididy

Could you rebase this onto master branch?

tbonelee avatar Oct 26 '25 08:10 tbonelee

You can see that request item 1 has been addressed in e92d5ae and item 2 in eea335a. Thank you for the thorough review.

dididy avatar Oct 27 '25 16:10 dididy

It took some time to incorporate the review feedback, do incremental refactoring, and clean up the tests that were failing in CI. I’ve opened #5128 with the common environment and utility changes. Once that PR is merged, I’ll follow up with the PRs below:

  • A PR reflecting changes to existing test POMs, utils, and specs
  • A PR for keyboard shortcut–related tests
  • A PR for the remaining notebook-related tests
  • A PR for tests related to shared modules (folder-rename, note-rename, note-toc)

Once all of those PRs are merged, we can close the current PR accordingly.

dididy avatar Dec 22 '25 13:12 dididy