zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

[ZEPPELIN-6312] Remove configuration WS usage in frontend

Open seung-00 opened this issue 4 months ago • 2 comments

What is this PR for?

This PR removes usage of the configuration API via WebSocket in the frontend.
The configuration API exists in both WS and REST, but unlike other APIs, it doesn’t seem to need two separate channels.
Maintaining both surfaces increases maintenance cost, so this PR unifies them by keeping only the REST API.

What type of PR is it?

Improvement

Todos

What is the Jira issue?

How should this be tested?

  • Check the configuration page (/configuration)
  • Check the notebook page (/notebook/{notebook_id})

Screenshots (if appropriate)

Questions:

  • Does the license files need to update? M
  • Is there breaking changes for older versions? N
  • Does this needs documentation? N

seung-00 avatar Aug 31 '25 08:08 seung-00

I’ve updated according to the review comments. But I found one issue: the configurations WS API has no auth check, while the REST API does. So users without permission can still access the configs via WS.

Removing WS right now would break things, so I’ll fix this in another PR before merging this one.

@tbonelee

seung-00 avatar Sep 06 '25 11:09 seung-00

image Could you also take a look at this? It seems that fetching configurations in `ConfigurationService.initialize()` when the user is not logged in might be causing some issues.

tbonelee avatar Sep 06 '25 13:09 tbonelee