zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

[ZEPPELIN-6054] Eliminate no-invalid-this warnings

Open cherrie-k opened this issue 1 year ago • 2 comments

What is this PR for?

This PR aims to refactor several parts of the Zeppelin project codebase to eliminate no-invalid-this warnings reported by ESLint. These warnings indicate that the this keyword is being used in ways that might lead to unexpected behavior or bugs, particularly within nested callbacks or when this loses its intended context. By addressing these warnings, we improve the stability, readability, and maintainability of the codebase.

Note on note-action.service.js: Initially, I aimed to refactor note-action.service.js to eliminate ESLint warnings. However, during testing, it was found that the note actions on the default page were not displaying correctly after the changes. To ensure the stability of the project, I have reverted the changes made to note-action.service.js. I plan to revisit this refactor to address the ESLint warnings while ensuring no issues arise in the build process.

What type of PR is it?

Refactoring

Todos

  • [x] - Resolve ESLint warnings of files in zeppelin-web/src/app
  • [ ] - Resolve ESLint warnings of files in zeppelin-web/src/components
  • [x] - Check if project compiles successfully

What is the Jira issue?

ZEPPELIN-6054

How should this be tested?

  • CI
  • Build and run

Screenshots (if appropriate)

Current Warnings: image

Questions:

  • Does the license files need to update? - No
  • Is there breaking changes for older versions? - No
  • Does this needs documentation? - No

cherrie-k avatar Aug 11 '24 06:08 cherrie-k

@seung-00 @tbonelee Can you verify the change again?

jongyoul avatar Aug 25 '24 05:08 jongyoul

Just a quick note: The force-push was to correct a typo in the commit message.

cherrie-k avatar Aug 25 '24 05:08 cherrie-k

Let me close and open it again to trigger CI properly.

jongyoul avatar Sep 08 '24 05:09 jongyoul

Thanks, merged to master for 0.12

pan3793 avatar Sep 20 '24 05:09 pan3793