zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

[ZEPPELIN-6018] Update gRPC version from 1.51.0 to 1.55.1 for successful Apache Zeppelin build on s390x architecture

Open aditi-sharma-1 opened this issue 10 months ago • 12 comments

This update modifies the grpc-java dependency version from 1.51.0 to 1.55.1. This change ensures compatibility and resolves build issues encountered on the s390x architecture. After implementing this change, the Apache Zeppelin package now builds successfully on the s390x architecture.

Attaching the log file and screenshots while building Apache Zeppelin on s390x:

build-on-s390x-logs.txt

build-screenshot-1 build-screenshot-2

aditi-sharma-1 avatar Apr 18 '24 10:04 aditi-sharma-1

Can you please create a JIRA ticket and update the license file. You can find a complete commit at https://github.com/apache/zeppelin/commit/09bd93877bbb0b352b0ef8efe9d53b227f3c8b87.

Reamer avatar Apr 19 '24 08:04 Reamer

Sure, I'll create the Jira ticket for this issue and update the license file. Thank you, Reamer.

aditi-sharma-1 avatar Apr 26 '24 05:04 aditi-sharma-1

By the way, could you please check the CI as well?

jongyoul avatar Apr 27 '24 12:04 jongyoul

Sure @jongyoul, I will check the CI.

I have also updated the license file and created the Jira ticket - 6018 Thank you.

aditi-sharma-1 avatar Apr 29 '24 09:04 aditi-sharma-1

Hmm... IIRC, there is a enforced rule to ensure that gRPC protobuf version aligned

pan3793 avatar Apr 29 '24 10:04 pan3793

@pan3793 Could you please elaborate ?

aditi-sharma-1 avatar Apr 30 '24 10:04 aditi-sharma-1

@aditi-sharma-1 ignore my previous comments, please follow the error reported by CI to fix it.

pan3793 avatar May 06 '24 17:05 pan3793

Sure @pan3793 ,

I have downgraded the gRPC version from 1.62.2 to 1.55.1. Could you please rerun it once? Thank you.

aditi-sharma-1 avatar May 09 '24 13:05 aditi-sharma-1

Sure @pan3793 ,

I have downgraded the gRPC version from 1.62.2 to 1.55.1. Could you please rerun it once? Thank you.

Sorry, I'm not a Zeppelin Committer thus I don't have power to rerun the CI. I saw another Committer triggered CI and the result looks good in this round.

pan3793 avatar May 13 '24 07:05 pan3793

@aditi-sharma-1 please update your PR title to something like [ZEPPELIN-6018] Update gRPC from 1.51.0 to 1.55.1, and since the Zeppelin existing CI does not have s390x machines, please update the PR description to mention your local test result on s390x

pan3793 avatar May 13 '24 07:05 pan3793

Sure, @pan3793 , I'll update the PR title and description Thank you.

aditi-sharma-1 avatar May 13 '24 11:05 aditi-sharma-1

CI failure should be irrelative, cc @jongyoul @huage1994 who has write permissions.

pan3793 avatar May 14 '24 09:05 pan3793