zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

[ZEPPELIN-5493] Remove prefix in jdbc interpreter

Open huage1994 opened this issue 3 years ago • 2 comments

What is this PR for?

Currently, zeppelin allow user to run multiple kinds of sql in one interpreter, e.g.

%jdbc(db=mysql)
%jdbc(db=hive){code}

  But this would make jdbc interpreter very complicated, and hard to maintain.   This PR is to proposal to remove this feature, so that user need to create separated interpreter for each database.

%mysql
%hive

What type of PR is it?

Refactoring

Todos

  • [ ] - Task

What is the Jira issue?

How should this be tested?

CI passed

Screenshots (if appropriate)

Questions:

  • Does the licenses files need to update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

huage1994 avatar Sep 09 '22 11:09 huage1994

BTW, don't it have a doc as well?

jongyoul avatar Sep 14 '22 05:09 jongyoul

BTW, don't it have a doc as well?

Thanks @jongyoul for reminding!
I found the hive related doc still have usage of this feature. I'll update it and verify.

huage1994 avatar Sep 14 '22 09:09 huage1994

BTW, don't it have a doc as well?

Thanks @jongyoul for reminding! I found the hive related doc still have usage of this feature. I'll update it and verify.

Finished.

huage1994 avatar Sep 28 '22 11:09 huage1994

LGTM, will merge if no more comment

zjffdu avatar Oct 25 '22 02:10 zjffdu

Hi @jongyoul , thanks a lot for your review! Is there any code I need to change? Merging can be performed automatically once the requested changes are addressed. It seems that change requested state can only be addressed by reviewer.

huage1994 avatar Oct 26 '22 04:10 huage1994