zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

[ZEPPELIN-5631] block notebook listed when user didn't have owner/reader/admin

Open woowahan-jaehoon opened this issue 3 years ago • 2 comments

What is this PR for?

Block notebook listed when user didn't have owner/reader/admin.

When I upgraded zeppelin 0.7 to 0.9, all notebooks are listed all users even if public option was disabled.

Runner permission is added after 0.7 so when upgrade 0.7 to 0.9, runner permission is set blank(all user allowed). user who has runner permission is allowed to read notebook, current logic.

What type of PR is it?

[Bug Fix]

Todos

  • Nothing

What is the Jira issue?

  • https://issues.apache.org/jira/browse/ZEPPELIN-5631

How should this be tested?

  • Set black to runner permission in notebook

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update?
    • No
  • Is there breaking changes for older versions?
    • No
  • Does this needs documentation?
    • No

woowahan-jaehoon avatar Jan 13 '22 18:01 woowahan-jaehoon

Should we fix it in the upgrading tool via setting the runner as the reader?

zjffdu avatar Jan 27 '22 03:01 zjffdu

I think that it is not enough that only apply upgrading tool because user can remove runner permission.

Possible to read notebook for runner without read permission is allowed?

woowahan-jaehoon avatar Mar 01 '22 07:03 woowahan-jaehoon