zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

[ZEPPELIN-5574] ConcurrentModificationException in JsonResponse.toString() when getNote with restAPI

Open zjffdu opened this issue 4 years ago • 3 comments
trafficstars

What is this PR for?

The root cause of this issue is that when Note is serialized to json, it is being modified by another thread. This PR use thread-safe class for Note/Paragraph.

What type of PR is it?

[Bug Fix ]

Todos

  • [ ] - Task

What is the Jira issue?

  • https://issues.apache.org/jira/browse/ZEPPELIN-5574

How should this be tested?

  • Tested it for 2 days in customer's environment and no issue happen again. (Before this PR, this issue happens everyday)

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

zjffdu avatar Oct 29 '21 08:10 zjffdu

@zjffdu I want to try to solve the concurrent problem in pull request #4252 with a ReentrantReadWriteLock. This solution should also catch this pull request.

Give me some time for the implementation.

Reamer avatar Nov 05 '21 07:11 Reamer

@Reamer Sure, let me know whey you are ready

zjffdu avatar Nov 05 '21 09:11 zjffdu

I merged #4252 into master. Please rebase to the current master. I think this PR is still needed.

Reamer avatar Jan 21 '22 08:01 Reamer