[ZEPPELIN-5249]. Update to thrift 0.14.2

[PrarthiJain]

trafficstars

What is this PR for?

• This PR is to upgrade thrift to 0.14.2

What type of PR is it?

• [Improvement]

Todos

• [ ] - Task

What is the Jira issue?

• https://issues.apache.org/jira/browse/ZEPPELIN-5249

How should this be tested?

• CI pass

Screenshots (if appropriate)

Questions:

• Does the licenses files need update? No
• Is there breaking changes for older versions? No
• Does this needs documentation? No

[PrarthiJain]

@prabhjyotsingh @VipinRathor @zjffdu, Could you please help in reviewing? Thanks.

[Reamer]

Please remove your changes in the zeppelin-web submodule. I closed your JIRA ticket because it duplicates another one. Please change your PR title and link in your PR text.

Maybe we can remove the System.exit(0) for a clean shutdown of the Zeppelin interpreter. It would be nice if you could test this. See https://issues.apache.org/jira/browse/ZEPPELIN-5249

[Reamer]

This PR also affects #4072, which still uses the old Thrift version.

[PrarthiJain]

Thanks, @Reamer. Could you please help with the steps to test for a successful shutdown of the Zeppelin interpreter?

[Reamer]

Thanks, @Reamer. Could you please help with the steps to test for a successful shutdown of the Zeppelin interpreter?

After #4072 has been merged, I can help you,

[PrarthiJain]

@Reamer The checks are unexpectedly failing. Could you please help with this, along with the code review? Thank you.

[Reamer]

CI is currently broken. Please rebase after #4107 is merged.

[Reamer]

#4107 was merged. Please rebase to current master.

[Reamer]

Please take a look at the Cassandra interpreter. I think the following stack trace relates to your change.

WARN  [07:27:58,378][] org.apache.cassandra.db.SystemKeyspace@:getLocalHostId No host ID found, created 729402a1-a3b2-482a-aeb7-7238ab0f53ff (Note: This should happen exactly once per node). 
Exception (java.lang.NoClassDefFoundError) encountered during startup: org/apache/thrift/transport/TFramedTransport$Factory
java.lang.NoClassDefFoundError: org/apache/thrift/transport/TFramedTransport$Factory
	at org.apache.cassandra.service.CassandraDaemon.setup(CassandraDaemon.java:435)
	at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:620)
	at org.cassandraunit.utils.EmbeddedCassandraServerHelper.lambda$startEmbeddedCassandra$1(EmbeddedCassandraServerHelper.java:152)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
	at java.lang.Thread.run(Thread.java:748)
Caused by: java.lang.ClassNotFoundException: org.apache.thrift.transport.TFramedTransport$Factory
	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:419)
	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
	at java.lang.ClassLoader.loadClass(ClassLoader.java:352)
	... 6 more

[zjffdu]

ping @PrarthiJain

[PrarthiJain]

@Reamer @zjffdu @prabhjyotsingh. I have uploaded a new patch with thrift dependency addition. We can remove that later on the 4.0 version upgrade. Let me know your thoughts. Thanks.

[zjffdu]

It looks like cause spark/flink tests fail

[PrarthiJain]

@Reamer @zjffdu @prabhjyotsingh, The build failed with Could not resolve dependencies for...from/to maven-default-http-blocker (http://0.0.0.0/): Blocked mirror for repositories: .... Could you please help? Thanks.

[zjffdu]

@PrarthiJain I also notice that today, I am looking into this issue, will keep you updated

[zjffdu]

@PrarthiJain I made a hotfix for the CI, please rebase your PR and trigger the CI again.

[PrarthiJain]

Thanks @zjffdu

[zjffdu]

@PrarthiJain Could you check the failed test ? AFAIK, frontend / test-selenium-with-spark-module-for-spark-2-3 and core / jdbcIntegrationTest-and-unit-test-of-Spark-2-4-with-Scala-2-11 has flaky tests, others should be successful.

[PrarthiJain]

It seems the Alluxio Interpreter Test is failing, should be fixed with- #2900.

[zjffdu]

@PrarthiJain What about other failed tests ?

[PrarthiJain]

@zjffdu Those were succeeded after re-triggering on my forked repo. However, I think I don't have permission to re-trigger and check the failed tests here. Do I need to upload a new patch again? Thanks.

[zjffdu]

@PrarthiJain You can do a force push to trigger the CI

[zjffdu]

@PrarthiJain AlluxioInterpreterTest is failed https://github.com/apache/zeppelin/pull/4089/checks?check_run_id=2801927837

[Reamer]

Thrift 0.14.2 has been released. This version also fixed a regression in the Java library. Maybe we should wait for this version.

[zjffdu]

ping @PrarthiJain

[PrarthiJain]

@Reamer @zjffdu @prabhjyotsingh, I have updated the patch. Could you please help to review it? Thanks.

[Reamer]

@Reamer @zjffdu @prabhjyotsingh, I have updated the patch. Could you please help to review it? Thanks.

I think your problems with updating the Thrift version are due to the ugly use of the interpreter shade jar.

https://github.com/apache/zeppelin/blob/0ec89755d3155c254bdf33cb7e9603f10708af65/zeppelin-interpreter-parent/pom.xml#L35-L46

I am trying to solve the problem in my interpreter_shade branch. . But the changes depend on an update of the shade-plugin (https://github.com/apache/maven-shade-plugin/pull/100 or https://github.com/apache/maven-shade-plugin/pull/105) because Intellji does not use the shading jars IDEA-93855 correctly.

[PrarthiJain]

Thanks, @Reamer. Sure will wait till the next release of maven-shade-plugin