zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

Change license to be compatible with license of com.hadoop.gplcompres…

Open kortemik opened this issue 4 years ago • 4 comments

…sion:hadoop-lzo:jar:0.4.19, see https://www.gnu.org/licenses/quick-guide-gplv3.html

What is this PR for?

Change license to be compatible with license of com.hadoop.gplcompression:hadoop-lzo:jar:0.4.19 https://github.com/twitter/hadoop-lzo/blob/master/src/main/java/com/hadoop/compression/lzo/CChecksum.java#L4-L7

see https://www.gnu.org/licenses/quick-guide-gplv3.html

What type of PR is it?

[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring] Hot Fix

Todos

  • [ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-5033

How should this be tested?

Purpose of this pull request is to deepen the discussion needed regarding this issue.

Screenshots (if appropriate)

Questions:

  • Does the licenses files need update? Yes
  • Is there breaking changes for older versions?
  • Does this needs documentation?

kortemik avatar Sep 10 '20 11:09 kortemik

Hi @kortemik, Can you give us a hint where the Zeppelin integrates Hadoop-lzo?

Reamer avatar Sep 10 '20 11:09 Reamer

Hi,

I think Scalding interpreter pulls it as a dependency: [INFO] Including com.hadoop.gplcompression:hadoop-lzo:jar:0.4.19 in the shaded jar.

kortemik avatar Sep 10 '20 12:09 kortemik

You are right. By the way, Scalding itself is licensed under the Apache License 2.0. https://github.com/twitter/scalding/blob/develop/LICENSE The library was added with the commit in scaling. https://github.com/twitter/scalding/commit/92a633db10eeac02a0faa6413a5969e85452381e

I am far from being a licensing expert, but maybe you can address a similar problem in the Scaling project.

Reamer avatar Sep 10 '20 13:09 Reamer

There we have it https://github.com/twitter/scalding/pull/1932 (:

kortemik avatar Sep 11 '20 09:09 kortemik