zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard

Published 20 hours ago • verified publisher icon apache

[ZEPPELIN-4383] Notebook Permalink Support

Open malayhm opened this issue 5 years ago • 3 comments

What is this PR for?

Support permalink of a note so that it can be shared with others

What type of PR is it?

Improvement

Todos

  • [ ] - Forward button should also change the active tab

What is the Jira issue?

  • https://issues.apache.org/jira/browse/ZEPPELIN-4383

How should this be tested?

  • Manually - open note, it should change the URL to reflect the note id

Screenshots (if appropriate)

NA

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this needs documentation? No

malayhm avatar Nov 10 '19 21:11 malayhm

Is the note link not permalink before this PR ? Is the note link the same as now ?

zjffdu avatar Nov 11 '19 02:11 zjffdu

@zjffdu

Before this PR, there was no permalink support in vue.js implementation.

Is the note link not permalink before this PR ?

Today, we have http://localhost:8080/#/notebook/<note_id> as permalink in Angular implementation, but with vue implementation, it will be http://localhost:8080/#/<note_id>. Should we change it to http://localhost:8080/#/notebook/<note_id> in this PR as well?

Is the note link the same as now ?

malayhm avatar Nov 15 '19 20:11 malayhm

Right, let's keep that the same as before, this is important for users to keep compatibility IMO.

zjffdu avatar Nov 16 '19 09:11 zjffdu