apache
[ZEPPELIN-4144] After refresh the revision tools are sometimes hidden
What is this PR for?
Fixes issue where after refreshing a note's page the revision controls in the navigation bar are hidden since listConfigurations is only requested in the navbar controller after a loginSuccess broadcast. This currently works sometimes because another controller (note-import) sends a listConfigurations request when it is loaded and navbar controller is sometimes loaded by the time the response arrives, but I can reproduce it easily using Firefox (gif attached to Jira issue).
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-4144
How should this be tested?
Added unit and e2e tests to make sure listConfigurations is called and controls are visible. Seems to me like the issue is easier to reproduce using Firefox. Was able to do so using the official 0.8.1 docker image.
Questions:
- Does the licenses files need update? No
- Is there breaking changes for older versions? No
- Does this needs documentation? No
Thanks @florpor for the contribution! Could you check message from Jenkins and try setup travis, and make CI test pass?
Looks like travis-ci is not configured for your fork.
Please setup by swich on 'zeppelin' repository at https://travis-ci.org/profile and travis-ci.
And then make sure 'Build branch updates' option is enabled in the settings https://travis-ci.org/florpor/zeppelin/settings.
To trigger CI after setup, you will need ammend your last commit with
git commit --amend
git push your-remote HEAD --force
See http://zeppelin.apache.org/contribution/contributions.html#continuous-integration.
Build step 'Execute shell' marked build as failure
Putting comment on the pull request
Finished: FAILURE
Let me know if you need any help setting up CI.
@Leemoonsoo I enabled travis and it took a few force-push-retries for all the jobs to succeed in one run. Now it seems that the travis_check.py script has had some error in the Jenkins job.