apache
[ZEPPELIN-2444] Better error message on shell timeout being reached.
What is this PR for?
Cue the user what the error they are getting is due to. I would get spurious timeouts, and I had no idea it was a timeout, and that I had the option of extending the timeout. Same issue as the reporter of ZEPPELIN-2444.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2444
How should this be tested?
Run sleep 61 and verify you get a nice error message. Unit test was updated.
Screenshots (if appropriate)
Questions:
- Does the licenses files need update? No
- Is there breaking changes for older versions? No
- Does this needs documentation? No.
It may be… I didn’t realize that it was until months later when I google around, and found the issue ZEPPELIN-2444!
When I got the SIGTERM error, I though it was my shell command (in my case a python pip install) had died due to something random, I didn’t think “oh, it took too long and hit a time out”….
On May 10, 2019, at 2:35 AM, Felix Cheung [email protected] wrote:
@felixcheung commented on this pull request.
In shell/src/main/java/org/apache/zeppelin/shell/ShellInterpreter.java https://github.com/apache/zeppelin/pull/3358#discussion_r282761598:
@@ -132,7 +132,7 @@ public InterpreterResult internalInterpret(String cmd, String message = outStream.toString(); if (exitValue == 143) { code = Code.INCOMPLETE;
message += "Paragraph received a SIGTERM\n";
message += "Timeout of " + getProperty(TIMEOUT_PROPERTY) + " ms to run reached.\n";hmm, I'm not sure these are the same? SIGTERM is not a timeout?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/apache/zeppelin/pull/3358#pullrequestreview-235944633, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAFO62ZQIZ24L4EOXZQ5KTPUUJUXANCNFSM4HL42F5A.
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com http://www.opensourceconnections.com/ | My Free/Busy http://tinyurl.com/eric-cal
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw
This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.
@epugh , I refactored the shell interpreter and are preparing to submit the PR, Has made the shell interpreter function exactly the same as the terminal。 ZEPPELIN-4131, Refactoring zeppelin shell interpreter Design Document
That definitly looks like a powerful feature! I saw it briefly when I was researching this PR…. I wasn’t sure the timeline to put this in! If this is the future, and the future is soon, please do close my PR in favor of this!
On May 10, 2019, at 5:42 AM, Xun Liu [email protected] wrote:
@epugh https://github.com/epugh , I refactored the shell interpreter and are preparing to submit the PR, Has made the shell interpreter function exactly the same as the terminal。 ZEPPELIN-4131 https://jira.apache.org/jira/browse/ZEPPELIN-4131, Refactoring zeppelin shell interpreter Design Document https://docs.google.com/document/d/1-XUkXY06cMtEUBxVHVyqQPkyCkv2BjYhAQj-W1CBxNI/edit#heading=h.hcfsn8dd2dw4 https://user-images.githubusercontent.com/3677382/57518103-e3e94300-734a-11e9-964b-fe95c6989ea9.gif — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/apache/zeppelin/pull/3358#issuecomment-491228442, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAFO6ZJI3NZQVDAMJJFU43PUU7QRANCNFSM4HL42F5A.
Eric Pugh | Founder & CEO | OpenSource Connections, LLC | 434.466.1467 | http://www.opensourceconnections.com http://www.opensourceconnections.com/ | My Free/Busy http://tinyurl.com/eric-cal
Co-Author: Apache Solr Enterprise Search Server, 3rd Ed https://www.packtpub.com/big-data-and-business-intelligence/apache-solr-enterprise-search-server-third-edition-raw
This e-mail and all contents, including attachments, is considered to be Company Confidential unless explicitly stated otherwise, regardless of whether attachments are marked as such.