zeppelin icon indicating copy to clipboard operation
zeppelin copied to clipboard
verified publisher icon apache

Fix abstractions. Removing Message class usage from NotebookService.

Open D01B opened this issue 6 years ago • 2 comments

What is this PR for?

Removing Message class usage from NotebookService. Using DTO object in services broke abstraction.

What type of PR is it?

[Improvement | Refactoring]

What is the Jira issue?

  • [ZEPPELIN-3958]
  • [ZP-104]

How should this be tested?

  • Travis CI pass

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

D01B avatar Jan 21 '19 14:01 D01B

I think if it is "public" API, strongly typed param is better?

felixcheung avatar Jan 24 '19 03:01 felixcheung

Could you add Jira Id in the PR title ?

zjffdu avatar Jan 27 '19 05:01 zjffdu