yunikorn-web
yunikorn-web copied to clipboard
apache
[YUNIKORN-2571] Add hierarchy icon to queue node
What is this PR for?
Add hierarchy icon to queue node icon from svgrepo which is MIT License
What type of PR is it?
- [x] - Improvement
What is the Jira issue?
Screenshots (if appropriate)
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 38.77%. Comparing base (
e4bc274) to head (62834b7). Report is 11 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #189 +/- ##
=======================================
Coverage 38.77% 38.77%
=======================================
Files 2 2
Lines 49 49
=======================================
Hits 19 19
Misses 27 27
Partials 3 3
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @wilfred-s, @craigcondit,
What else we need to do to include the image from MIT license?
The MIT lincese says "The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software."
We need to add a couple of lines to the License file. Like we did in the k8shim LICENSE file:
--------------------------------------------------------------------------------
This product bundles various third-party components under other open source
licenses. This section summarizes those components and their licenses.
MIT License
------------
src/assets/images/hierarchy.svg
Besides that the repo has the following comment: https://www.svgrepo.com/page/licensing/ So we can add a text to the about box which we already need for our 3rd party licenses to make them easily accessible. This was doen in YUNIKORN-2448 so we should be able to piggy-back on that one
