yunikorn-k8shim icon indicating copy to clipboard operation
yunikorn-k8shim copied to clipboard

[YUNIKORN-2617] Update kindest/node to v1.29.2 for Makefile

Open ryankert01 opened this issue 9 months ago • 1 comments

What is this PR for?

as title, follow up of https://github.com/apache/yunikorn-k8shim/pull/833

What type of PR is it?

  • [ ] - Bug Fix
  • [x] - Improvement
  • [ ] - Feature
  • [ ] - Documentation
  • [ ] - Hot Fix
  • [ ] - Refactoring

Todos

  • [ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2617

How should this be tested?

Github CI

Screenshots (if appropriate)

Questions:

  • [ ] - The licenses files need update.
  • [ ] - There is breaking changes for older versions.
  • [ ] - It needs documentation.

ryankert01 avatar May 10 '24 12:05 ryankert01

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 66.06%. Comparing base (e95ba07) to head (13a2ae9).

:exclamation: Current head 13a2ae9 differs from pull request most recent head d215e39. Consider uploading reports for the commit d215e39 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #836      +/-   ##
==========================================
+ Coverage   66.03%   66.06%   +0.02%     
==========================================
  Files          69       69              
  Lines        7550     7547       -3     
==========================================
  Hits         4986     4986              
+ Misses       2351     2348       -3     
  Partials      213      213              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 10 '24 12:05 codecov[bot]

@ryankert01 please do a proper rebase. Now there are multiple commits that are already on master, quite a few changes in 16 files are shown (not sure why though).

pbacsko avatar May 13 '24 08:05 pbacsko

@pbacsko Looks like it's because I forgot to sync my master branch. Thank you for your time.

ryankert01 avatar May 13 '24 11:05 ryankert01