yunikorn-k8shim icon indicating copy to clipboard operation
yunikorn-k8shim copied to clipboard

[WIP] [YUNIKORN-1795] Remove the scheduling cycle in the shim

Open pbacsko opened this issue 1 year ago • 1 comments

What is this PR for?

The periodic scheduling cycle in the shim is not needed. We can directly forward an incoming task to the core if possible.

What type of PR is it?

  • [ ] - Bug Fix
  • [x] - Improvement
  • [ ] - Feature
  • [ ] - Documentation
  • [ ] - Hot Fix
  • [ ] - Refactoring

Todos

  • [ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1795

How should this be tested?

Screenshots (if appropriate)

Questions:

  • [ ] - The licenses files need update.
  • [ ] - There is breaking changes for older versions.
  • [ ] - It needs documentation.

pbacsko avatar Jan 16 '24 15:01 pbacsko

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (3c78e59) 71.32% compared to head (589af92) 71.84%.

:exclamation: Current head 589af92 differs from pull request most recent head 3ce0776. Consider uploading reports for the commit 3ce0776 to get more accurate results

Files Patch % Lines
pkg/cache/task.go 79.31% 5 Missing and 1 partial :warning:
pkg/cache/application.go 92.59% 3 Missing and 1 partial :warning:
pkg/cache/context.go 76.92% 2 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #765      +/-   ##
==========================================
+ Coverage   71.32%   71.84%   +0.52%     
==========================================
  Files          43       43              
  Lines        7592     7626      +34     
==========================================
+ Hits         5415     5479      +64     
+ Misses       1976     1944      -32     
- Partials      201      203       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 16 '24 16:01 codecov[bot]