yunikorn-k8shim icon indicating copy to clipboard operation
yunikorn-k8shim copied to clipboard

[YUNIKORN-2135] Add integration test code coverage

Open FrankYang0529 opened this issue 1 year ago • 3 comments

What is this PR for?

If ENABLE_GO_COVER_DIR is TRUE:

  • Add cover flags to go build.
  • Use root user to build docker images.
  • Add uninstall_yunikorn and copy_go_cover_dir to run-e2e-tests.sh.

What type of PR is it?

  • [X] - Improvement

Todos

  • [ ] Wait for https://github.com/apache/yunikorn-release/pull/164.
  • [x] Update workflow to send codecov data

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-2135

FrankYang0529 avatar Nov 22 '23 16:11 FrankYang0529

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c5a82ac) 69.43% compared to head (3f1e58d) 77.30%. Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
+ Coverage   69.43%   77.30%   +7.86%     
==========================================
  Files          50       73      +23     
  Lines        7993     9284    +1291     
==========================================
+ Hits         5550     7177    +1627     
+ Misses       2254     1848     -406     
- Partials      189      259      +70     
Flag Coverage Δ
e2e 63.79% <ø> (?)
unittests 69.43% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 26 '23 05:11 codecov[bot]

@FrankYang0529 could you resolve the merge conflicts?

pbacsko avatar Feb 09 '24 07:02 pbacsko

@FrankYang0529 can we write the logs to a directory under /tmp in the container? I'm not a fan of a top-level dir for this...

craigcondit avatar Feb 14 '24 16:02 craigcondit