yunikorn-k8shim icon indicating copy to clipboard operation
yunikorn-k8shim copied to clipboard

[YUNIKORN-1375] [shim] pass group info from the shim to the core

Open pbacsko opened this issue 2 years ago • 1 comments

What is this PR for?

The list of groups in si.AddApplicationRequest is not passed from the shim to core. We need to make sure that we store the group inside the Application object and pass them when needed.

What type of PR is it?

  • [x] - Bug Fix
  • [ ] - Improvement
  • [ ] - Feature
  • [ ] - Documentation
  • [ ] - Hot Fix
  • [ ] - Refactoring

Todos

  • [ ] - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/YUNIKORN-1375

How should this be tested?

Screenshots (if appropriate)

Questions:

  • [ ] - The licenses files need update.
  • [ ] - There is breaking changes for older versions.
  • [ ] - It needs documentation.

pbacsko avatar Oct 28 '22 12:10 pbacsko

Codecov Report

Merging #470 (af8e19b) into master (26fe2df) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #470      +/-   ##
==========================================
+ Coverage   68.01%   68.03%   +0.02%     
==========================================
  Files          42       42              
  Lines        6916     6921       +5     
==========================================
+ Hits         4704     4709       +5     
  Misses       2042     2042              
  Partials      170      170              
Impacted Files Coverage Δ
pkg/cache/amprotocol_mock.go 54.54% <100.00%> (+0.52%) :arrow_up:
pkg/cache/application.go 71.96% <100.00%> (+0.17%) :arrow_up:
pkg/cache/context.go 45.04% <100.00%> (+0.07%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Oct 28 '22 12:10 codecov[bot]