yunikorn-core
yunikorn-core copied to clipboard
[YUNIKORN-491] Inject Tracing Logic in the Core's Scheduling Procedures
This PR is a draft for injecting scheduling tracing logic. We have to pass trace context to every function that we trace and I add it as function parameter. I'm wondering if these changes is appropriate.
I didn't modify test code in this draft. I think it's better to have a discussion about these changes on before I go on.
Related Issue: https://issues.apache.org/jira/browse/YUNIKORN-491
Hi @yangwwei Could you please give us some suggestion on this draft? I really appreciate it.
Codecov Report
Merging #241 (cc19c59) into master (5a1c19e) will decrease coverage by
0.64%
. The diff coverage is49.93%
.
@@ Coverage Diff @@
## master #241 +/- ##
==========================================
- Coverage 63.46% 62.82% -0.65%
==========================================
Files 60 59 -1
Lines 5220 5630 +410
==========================================
+ Hits 3313 3537 +224
- Misses 1747 1927 +180
- Partials 160 166 +6
Impacted Files | Coverage Δ | |
---|---|---|
pkg/scheduler/context.go | 5.52% <0.00%> (-0.74%) |
:arrow_down: |
pkg/scheduler/nodes_usage_monitor.go | 0.00% <0.00%> (ø) |
|
pkg/scheduler/objects/allocation.go | 100.00% <ø> (ø) |
|
pkg/scheduler/objects/queue.go | 65.73% <12.50%> (-3.72%) |
:arrow_down: |
pkg/scheduler/objects/application.go | 49.37% <35.26%> (+0.46%) |
:arrow_up: |
pkg/trace/scheduler_tracer.go | 56.81% <44.82%> (-25.69%) |
:arrow_down: |
pkg/scheduler/partition_manager.go | 20.00% <50.00%> (ø) |
|
pkg/scheduler/partition.go | 69.35% <73.18%> (+3.31%) |
:arrow_up: |
pkg/scheduler/objects/node.go | 81.98% <75.00%> (+0.16%) |
:arrow_up: |
pkg/trace/context.go | 94.91% <75.00%> (ø) |
|
... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c21ca31...cc19c59. Read the comment docs.
Closing the PR as it has not been updated for 2 years. The overall jira for tracing is open and will remain open as we still might look at implementing the tracing.