wicket
wicket copied to clipboard
Error page redirection support for autocomplete ajax response
Autocomplete field resulting an exception with org.apache.wicket.settings.ExceptionSettings#errorHandlingStrategyDuringAjaxRequests, set to org.apache.wicket.settings.ExceptionSettings.AjaxErrorStrategy.REDIRECT_TO_ERROR_PAGE
does not redirect to the error page.
This fix will enable page redirection even for autocomplete field.
Not sure about JavaScript test added, as I see all tests (part of all.html) go green always.
wicket-core/src/test/js/** cover only the .js files in -core. There are no unit JS tests for -extensions module. In https://github.com/apache/wicket/tree/master/wicket-examples/src/main/webapp/js-test there are functional tests though for some of the examples. There is no such for the autocomplete example yet.
Please create a ticket in JIRA with a quickstart for the problem in autocomplete. I just checked the diff and I see that you actually modified wicket-ajax-jquery.js, not wicket-autocomplete.js. Changes here need more attention before applying!
Yes, changes to wicket-ajax-jquery.js need more attention, created a ticket for it with description https://issues.apache.org/jira/browse/WICKET-6075
This PR seems to be inactive for too long :( I guess it can be dropped? :)